Commit 13bbfb4a authored by Sam Protsenko's avatar Sam Protsenko Committed by Tom Rini
Browse files

env: Don't show "Failed" error message



"Failed" error message from env_load() only clutters the log with
unnecessary details, as we already have all needed warnings by that
time. Example:

    Loading Environment from FAT... MMC: no card present
    ** Bad device mmc 0 **
    Failed (-5)

Let's only print it in case when DEBUG is defined to keep log clear.
Signed-off-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
parent 60a4df32
......@@ -186,14 +186,18 @@ int env_load(void)
continue;
printf("Loading Environment from %s... ", drv->name);
/*
* In error case, the error message must be printed during
* drv->load() in some underlying API, and it must be exactly
* one message.
*/
ret = drv->load();
if (ret)
printf("Failed (%d)\n", ret);
else
if (ret) {
debug("Failed (%d)\n", ret);
} else {
printf("OK\n");
if (!ret)
return 0;
}
}
/*
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment