Commit 2fcd7489 authored by Samuel Holland's avatar Samuel Holland Committed by André Przywara
Browse files

sunxi: board: Use a more descriptive variable name

The variable "cmp_str" always leaves me wondering if it is the DT name
of the current board (yes) or DT name in the FIT config entry (no).

In preparation for expanding the functionality here, rename it to
something that obviously means "this is the DT name we are looking for".
Acked-by: default avatarMaxime Ripard <>
Reviewed-by: André Przywara's avatarAndre Przywara <>
Signed-off-by: default avatarSamuel Holland <>
Reviewed-by: Jagan Teki's avatarJagan Teki <>
parent 9324c9a8
......@@ -892,14 +892,14 @@ int ft_board_setup(void *blob, struct bd_info *bd)
int board_fit_config_name_match(const char *name)
struct boot_file_head *spl = get_spl_header(SPL_DT_HEADER_VERSION);
const char *cmp_str = (const char *)spl;
const char *best_dt_name = (const char *)spl;
/* Check if there is a DT name stored in the SPL header and use that. */
if (spl != INVALID_SPL_HEADER && spl->dt_name_offset) {
cmp_str += spl->dt_name_offset;
best_dt_name += spl->dt_name_offset;
} else {
return 0;
......@@ -907,15 +907,15 @@ int board_fit_config_name_match(const char *name)
/* Differentiate the two Pine64 board DTs by their DRAM size. */
if (strstr(name, "-pine64") && strstr(cmp_str, "-pine64")) {
if (strstr(name, "-pine64") && strstr(best_dt_name, "-pine64")) {
if ((gd->ram_size > 512 * 1024 * 1024))
return !strstr(name, "plus");
return !!strstr(name, "plus");
} else {
return strcmp(name, cmp_str);
return strcmp(name, best_dt_name);
return strcmp(name, cmp_str);
return strcmp(name, best_dt_name);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment