Skip to content
  • Masayoshi Mizuma's avatar
    tools/testing/nvdimm: Fix the array size for dimm devices. · af31b04b
    Masayoshi Mizuma authored
    KASAN reports following global out of bounds access while
    nfit_test is being loaded. The out of bound access happens
    the following reference to dimm_fail_cmd_flags[dimm]. 'dimm' is
    over than the index value, NUM_DCR (==5).
    
      static int override_return_code(int dimm, unsigned int func, int rc)
      {
              if ((1 << func) & dimm_fail_cmd_flags[dimm]) {
    
    dimm_fail_cmd_flags[] definition:
      static unsigned long dimm_fail_cmd_flags[NUM_DCR];
    
    'dimm' is the return value of get_dimm(), and get_dimm() returns
    the index of handle[] array. The handle[] has 7 index. Let's use
    ARRAY_SIZE(handle) as the array size.
    
    KASAN report:
    
    ==================================================================
    BUG: KASAN: global-out-of-bounds in nfit_test_ctl+0x47bb/0x55b0 [nfit_test]
    Read of size 8 at addr ffffffffc10cbbe8 by task kworker/u41:0/8
    ...
    Call Trace:
     dump_stack+0xea/0x1b0
     ? dump_stack_print_info.cold.0+0x1b/0x1b
     ? kmsg_dump_rewind_nolock+0xd9/0xd9
     print_address_description+0x65/0x22e
     ? nfit_test_ctl+0x47bb/0x55b0 [nfit_test]
     kasan_report.cold.6+0x92/0x1a6
     nfit_test_ctl+0x47bb/0x55b0 [nfit_test]
    ...
    The buggy address belongs to the variable:
     dimm_fail_cmd_flags+0x28/0xffffffffffffa440 [nfit_test]
    ==================================================================
    
    Fixes: 39611e83
    
     ("tools/testing/nvdimm: Make DSM failure code injection...")
    Signed-off-by: default avatarMasayoshi Mizuma <m.mizuma@jp.fujitsu.com>
    Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
    af31b04b