• Chris Mason's avatar
    Btrfs: clear the extent uptodate bits during parent transid failures · 50653190
    Chris Mason authored
    If btrfs reads a block and finds a parent transid mismatch, it clears
    the uptodate flags on the extent buffer, and the pages inside it.  But
    we only clear the uptodate bits in the state tree if the block straddles
    more than one page.
    This is from an old optimization from to reduce contention on the extent
    state tree.  But it is buggy because the code that retries a read from
    a different copy of the block is going to find the uptodate state bits
    set and skip the IO.
    The end result of the bug is that we'll never actually read the good
    copy (if there is one).
    The fix here is to always clear the uptodate state bits, which is safe
    because this code is only called when the parent transid fails.
    Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
extent_io.c 109 KB