• Linus Torvalds's avatar
    f2fs/crypto: fix xts_tweak initialization · 02fc59a0
    Linus Torvalds authored
    Commit 0b81d077 ("fs crypto: move per-file encryption from f2fs
    tree to fs/crypto") moved the f2fs crypto files to fs/crypto/ and
    renamed the symbol prefixes from "f2fs_" to "fscrypt_" (and from "F2FS_"
    to just "FS" for preprocessor symbols).
    
    Because of the symbol renaming, it's a bit hard to see it as a file
    move: use
    
        git show -M30 0b81d077
    
    
    
    to lower the rename detection to just 30% similarity and make git show
    the files as renamed (the header file won't be shown as a rename even
    then - since all it contains is symbol definitions, it looks almost
    completely different).
    
    Even with the renames showing as renames, the diffs are not all that
    easy to read, since so much is just the renames.  But Eric Biggers
    noticed that it's not just all renames: the initialization of the
    xts_tweak had been broken too, using the inode number rather than the
    page offset.
    
    That's not right - it makes the xfs_tweak the same for all pages of each
    inode.  It _might_ make sense to make the xfs_tweak contain both the
    offset _and_ the inode number, but not just the inode number.
    Reported-by: default avatarEric Biggers <ebiggers3@gmail.com>
    Cc: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    02fc59a0