Skip to content
  • Antonino A. Daplas's avatar
    [PATCH] vgacon: Fix usage of stale height value on vc initialization · 5ef897c7
    Antonino A. Daplas authored
    
    
    Reported by: Wayne E. Harlan
    
    "[1.] One line summary of the problem:
    When the kernel option "vga=1" is used, additional tty's (alt+control+Fx
    with x=2,3,4,5, etc) do not provide the full 50 lines of output.  The first
    one does have 50 lines, however.
    
    [2.] Full description of the problem/report:
    These addtitional tty's show only 39 lines plus the top pixel of the 40-th
    line.  The remaining lines are black and not shown.  Kernel version
    2.6.13.4 does not show this problem."
    
    This bug is caused by using a stale font height value on vgacon_init.
    
    Booting with vga=1 gives an 80x50 screen with an 8x8 font.  Somewhere
    during the initialization, the font was changed to 8x9 and the first
    vc was correctly resized to 80x44.  However, the rest of the vc's were
    not allocated yet, and when they were subsequently initialized, they
    still used a font height of 8 (instead of 9) causing the mentioned bug.
    
    Fix by saving the new font height to vga_video_font_height.
    
    Signed-off-by: default avatarAntonino Daplas <adaplas@pol.net>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    5ef897c7