Skip to content
  • Dmitry Monakhov's avatar
    ext4: unregister es_shrinker if mount failed · a75ae78f
    Dmitry Monakhov authored
    
    
    Otherwise destroyed ext_sb_info will be part of global shinker list
    and result in the following OOPS:
    
    JBD2: corrupted journal superblock
    JBD2: recovery failed
    EXT4-fs (dm-2): error loading journal
    general protection fault: 0000 [#1] SMP
    Modules linked in: fuse acpi_cpufreq freq_table mperf coretemp kvm_intel kvm crc32c_intel microcode sg button sd_mod crc_t10dif ahci libahci pata_acpi ata_generic dm_mirror dm_region_hash dm_log dm_\
    mod
    CPU 1
    Pid: 2758, comm: mount Not tainted 3.8.0-rc3+ #136                  /DH55TC
    RIP: 0010:[<ffffffff811bfb2d>]  [<ffffffff811bfb2d>] unregister_shrinker+0xad/0xe0
    RSP: 0000:ffff88011d5cbcd8  EFLAGS: 00010207
    RAX: 6b6b6b6b6b6b6b6b RBX: 6b6b6b6b6b6b6b53 RCX: 0000000000000006
    RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000246
    RBP: ffff88011d5cbce8 R08: 0000000000000002 R09: 0000000000000001
    R10: 0000000000000001 R11: 0000000000000000 R12: ffff88011cd3f848
    R13: ffff88011cd3f830 R14: ffff88011cd3f000 R15: 0000000000000000
    FS:  00007f7b721dd7e0(0000) GS:ffff880121a00000(0000) knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
    CR2: 00007fffa6f75038 CR3: 000000011bc1c000 CR4: 00000000000007e0
    DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
    Process mount (pid: 2758, threadinfo ffff88011d5ca000, task ffff880116aacb80)
    Stack:
    ffff88011cd3f000 ffffffff8209b6c0 ffff88011d5cbd18 ffffffff812482f1
    00000000000003f3 00000000ffffffea ffff880115f4c200 0000000000000000
    ffff88011d5cbda8 ffffffff81249381 ffff8801219d8bf8 ffffffff00000000
    Call Trace:
    [<ffffffff812482f1>] deactivate_locked_super+0x91/0xb0
    [<ffffffff81249381>] mount_bdev+0x331/0x340
    [<ffffffff81376730>] ? ext4_alloc_flex_bg_array+0x180/0x180
    [<ffffffff81362035>] ext4_mount+0x15/0x20
    [<ffffffff8124869a>] mount_fs+0x9a/0x2e0
    [<ffffffff81277e25>] vfs_kern_mount+0xc5/0x170
    [<ffffffff81279c02>] do_new_mount+0x172/0x2e0
    [<ffffffff8127aa56>] do_mount+0x376/0x380
    [<ffffffff8127ab98>] sys_mount+0x138/0x150
    [<ffffffff818ffed9>] system_call_fastpath+0x16/0x1b
    Code: 8b 05 88 04 eb 00 48 3d 90 ff 06 82 48 8d 58 e8 75 19 4c 89 e7 e8 e4 d7 2c 00 48 c7 c7 00 ff 06 82 e8 58 5f ef ff 5b 41 5c c9 c3 <48> 8b 4b 18 48 8b 73 20 48 89 da 31 c0 48 c7 c7 c5 a0 e4 81 e\
    8
    RIP  [<ffffffff811bfb2d>] unregister_shrinker+0xad/0xe0
    RSP <ffff88011d5cbcd8>
    
    Signed-off-by: default avatarDmitry Monakhov <dmonakhov@openvz.org>
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    Cc: stable@vger.kernel.org
    a75ae78f