Skip to content
  • NeilBrown's avatar
    [PATCH] md: fix is_mddev_idle calculation now that disk/sector accounting... · c0e48521
    NeilBrown authored
    
    [PATCH] md: fix is_mddev_idle calculation now that disk/sector accounting happens when request completes
    
    md needs to monitor the rate of requests to its devices when doing
    resync/recovery so that it can back-off when there is non-resync IO.  It
    does this by comparing resync IO, which it counts, with total IO which is
    taken from disk_stats.
    
    disk_stats were recently changed to account sectors when a request
    completes instead of when it is queued.  This upsets md's calculations.
    
    We could do the sync_io accounting at the end of requests too, but that has
    problems.  If an underlying device is an md array, the accounting will
    still be done when the request is submitted.  This could be changed for
    some raid levels, but it cannot be changed for raid0 or linear without
    substantial code changes.
    
    So instead, we increase the error that is_mddev_idle allows, up to the
    maximum amount of resync IO that can be in flight at any time.  The
    calculation is current fragile as each personality as different limits for
    in-flight resync.  This should be fixed up.
    
    For now, this simple patch fixes the problem.
    
    Increasing the error margin decreases the sensitivity to non-resync IO.  To
    partially compensate for this, the time to wait when non-resync IO is
    detected is increased so that less steady IO is required to keep the resync
    at bay.
    
    Signed-off-by: default avatarNeil Brown <neilb@suse.de>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    c0e48521