Skip to content
  • Eric W. Biederman's avatar
    sysfs: Make sysfs_rename safe with sysfs_dirents in rbtrees. · f6d90b4f
    Eric W. Biederman authored
    
    
    In sysfs_rename we need to remove the optimization of not calling
    sysfs_unlink_sibling and sysfs_link_sibling if the renamed parent
    directory is not changing.  This optimization is no longer valid now
    that sysfs dirents are stored in an rbtree sorted by name.
    
    Move the assignment of s_ns before the call of sysfs_link_sibling.  With
    no sysfs_dirent fields changing after the call of sysfs_link_sibling
    this allows sysfs_link_sibling to take any of the directory entries into
    account when it builds the rbtrees, and s_ns looks like a prime canidate
    to be used in the rbtree in the future.
    
    Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
    Cc: Jiri Slaby <jirislaby@gmail.com>
    Cc: Greg KH <gregkh@suse.de>
    Cc: David Miller <davem@davemloft.net>
    Cc: Mikulas Patocka <mpatocka@redhat.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f6d90b4f