Skip to content
Snippets Groups Projects
Commit 84799021 authored by Sean Anderson's avatar Sean Anderson Committed by Jaehoon Chung
Browse files

power-domain: Fix use of uninitialized value in dev_power_domain_ctrl


If dev_count_phandle_with_args returns 0 or another error, then pd will never
have been initialized by power_domain_get_by_index. Avoid comparing against
pd.dev in this situation.

Fixes: 3e4fcfa4 ("power-domain: fix hang in endless loop on i.MX8")
Signed-off-by: default avatarSean Anderson <seanga2@gmail.com>
Reviewed-by: Simon Glass's avatarSimon Glass <sjg@chromium.org>
Reviewed-by: default avatarJaehoon Chung <jh80.chung@samsung.com>
parent ea5583b9
No related branches found
No related tags found
No related merge requests found
......@@ -137,7 +137,7 @@ static int dev_power_domain_ctrl(struct udevice *dev, bool on)
* off their power-domain parent. So we will get here again and
* again and will be stuck in an endless loop.
*/
if (!on && dev_get_parent(dev) == pd.dev &&
if (count > 0 && !on && dev_get_parent(dev) == pd.dev &&
device_get_uclass_id(dev) == UCLASS_POWER_DOMAIN)
return ret;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment