- Sep 26, 2024
-
-
Simon Glass authored
This patch is for Marek, to provide a starting point. To try it, use 'binman test -T' and see the missing coverage. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Some images do not have an image_pos value, for example an image which is part of a compressed section and therefore cannot be accessed directly. Handle this case, returning None as the value. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Move the check for this further out, so that base_addr is computed in Entry.WriteSymbols() rather than at lower levels. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
The base address of the ELF containing symbols is normally added to any symbols written, so that the value points to the correct address in memory when everything is loaded. When the binary resides on disk, a different offset may be needed, typically 0. Provide a way to specify this. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Add a clarification to the documentation and add a missing comment. Also update the test so that when it fails it is easier to see what is going on, rather than having to decode hex strings. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
These functions get the value of a symbol. The reference to ELF files is confusing since they are reading the position/size of entries, not ELF symbols. Rename the functions and adjust the comments also. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
With OF_UPSTREAM the dts files are in an SoC-specific subdirectory, meaning that the resulting dtb files all end up in a similar subdirectory. We don't want the subdirectory name to appear as a node name in the FIT, so handle this as a special case. Also the default devicetree may have a directory-name prefix, so handle that when searching through the available devicetree files. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
The section etype has its own implementation of SetImagePos(), most of which is not useful since the code is included here. So call Entry.SetImagePos() which has the only piece of this which we actually want. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Use the more generic variable name 'entry' to avoid confusion. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Since the files are known to be in the provided directory, use that instead of requiring it to be added to the list of input directories. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Two places set this attribute directly. Update them to use the function provided. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Update this entry type to resolve some pylint warnings and make sure that functions and members are fully commented. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Improve the comments for this function. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
This returns stdout, not a CommandResult so update the comment. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Add tests for missing tools to complete the test coverage for this etype. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
For most boards, the device-tree compiler is built in-tree, ignoring the system version. Add a special option to skip this build. This can be useful when the system dtc is up-to-date, as it speeds up the build. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Buildman retries a failed build when processing a branch, but does not do this when building current source. It is useful to do this retry in both cases, so add the logic for it. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
- Sep 25, 2024
-
-
dev_get_driver_ops() may return NULL when the udevice is invalid. Move the ops check to top of functions to consistently return -ENOSYS when ops is unimplemented and prevent trying to access uclass plat data, also add missing NULL checks to suspend ops. Signed-off-by:
Jonas Karlman <jonas@kwiboo.se>
-
On some boards a PMIC regulator is flagged with regulator-on-in-suspend and does not define any suspend or max microvolt, e.g. on Radxa ROCK 3A: vcc_ddr: DCDC_REG3 { regulator-name = "vcc_ddr"; regulator-always-on; regulator-boot-on; regulator-initial-mode = <0x2>; regulator-state-mem { regulator-on-in-suspend; }; }; This result in suspend_uV having the value -ENODATA after probe. This negative voltage, -ENODATA, gets missinterpreted and result in an unexpected voltage being set by autoset. E.g. on Radxa ROCK 3A the vcc_ddr regulator by default have a normal and suspend voltage value of 0.5v. However, due to this missinterpretation the suspend voltage end up beind set to 0.5625v instead. Fix this by skip calling regulator_set_suspend_value() in autoset and also protect calling set value ops when input value is -ENODATA. Signed-off-by:
Jonas Karlman <jonas@kwiboo.se>
-
Tom Rini authored
Merge tag 'u-boot-imx-next-20240925' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx into next CI: https://source.denx.de/u-boot/custodians/u-boot-imx/-/pipelines/22406 - i.MX93 FEC fixes. - Always name the generated fitImage u-boot.itb to keep compatibility with pr-buildman behavior. -----------------------
-
- Sep 24, 2024
-
-
Ye Li authored
After FEC is halted by calling fec_halt callback, we should not continue receiving packet. Otherwise it will process previous pending interrupts on EIR register and uses wrong rbd index as this has been reset to 0. The GRA interrupt which is triggered by issuing graceful stop command to FEC transmitter in fec_halt is processed in this case. It causes wrong receive buffer descriptors be used by FEC in next time. Signed-off-by:
Ye Li <ye.li@nxp.com> Reviewed-by:
Peng Fan <peng.fan@nxp.com> Signed-off-by:
Peng Fan <peng.fan@nxp.com>
-
Peng Fan authored
i.MX93 FEC ENET port supports two mode: RGMII and RMII. For RGMII, there is an internal /2 divider, so the freq needs to set with (*2), otherwise the speed will not reach 1G and cause communication error in some network environments. For RMII, the clk path is ccm -> enet tx_clk pin -> pad loop back to enet, no /2 divider. So fix for RGMII mode with freq multiplied by 2. Fixes: 09de565f ("net: fec_mxc: support i.MX93") Signed-off-by:
Ye Li <ye.li@nxp.com> Signed-off-by:
Peng Fan <peng.fan@nxp.com>
-
Marek Vasut authored
Maintain backward compatibility with pre-binman u-boot file naming, the U-Boot fitImage used to be named u-boot.itb before, restore the file name after binman conversion. Signed-off-by:
Marek Vasut <marex@denx.de> Reviewed-by:
Peng Fan <peng.fan@nxp.com>
-
Tom Rini authored
Jerome Forissier <jerome.forissier@linaro.org> says: Miscellaneous fixes made when developing the lwIP series [1]. They are posted separately since they make sense on their own. Subsequent versions of the lwIP series will contain a squashed version of this one. [1] http://patchwork.ozlabs.org/project/uboot/list/?series=420712&state=%2A&archive=both
-
cmd/pxe.c (CMD_PXE) calls do_get_tftp() (CMD_TFTPBOOT) therefore add an "imply" to cmd/Kconfig. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com>
-
common/update.c (UPDATE_COMMON) depends on tftp_timeout_ms which is defined in cmd/tftp.c (CMD_TFTPBOOT). Therefore add the appropriate imply statement to Kconfig. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com>
-
Add a test to test_efi_loader.py similar to the TFTP test but for HTTP with the wget command. Suggested-by:
Tom Rini <trini@konsulko.com> Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Tested-by:
Tom Rini <trini@konsulko.com> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com>
-
test_efi_helloworld_net() and test_efi_grub_net() depend on cmd_tftpboot so add the missing annotations. Reported-by:
Tom Rini <trini@konsulko.com> Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org>
-
If env__pxe_boot_test_skip is not present, it defaults to True not False. Therefore fix the comment. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org>
-
The fec_mxc_init() function currently always returns 0. This does not allow the callers to detect when for instance the PHY initialization failed due to the port being unconnected. Fix that by returning the status of fec_open(). Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Fabio Estevam <festevam@gmail.com> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org>
-
wget followed by bootefi currently fails as follows: U-Boot> wget 200000 192.168.0.30:helloworld.efi Waiting for Ethernet connection... done. HTTP/1.0 200 OK Packets received 13, Transfer Successful Bytes transferred = 12720 (31b0 hex) U-Boot> bootefi 200000 No UEFI binary known at 200000 U-Boot> Fix the problem by adding the missing efi_set_bootdev() call. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
FTGMAC100 enables drivers/net/ftgmac100.c which uses PHY_INTERFACE_MODE_NCSI, which is defined only when PHY_NCSI is enabled. Therefore FTGMAC100 depends on PHY_NCSI. However adding such a dependency causes a "recursive dependency detected!" message, so add a dependency on NET instead (PHY_NCSI depends on NET). All in all, either the stack is NET and FTGMAC100 can be enabled, or it is NET_LWIP (or NO_NET) and it cannot. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
PHY_NCSI enables drivers/net/phy/ncsi.c which calls net_loop() and net_set_timeout_handler(). That's the legacy NET stack (as opposed to NET_LWIP). Therefore add the dependency to Kconfig. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org>
-
wget_success() is used nowhere so remove it. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com>
-
dtsec_init_phy() is defined only with MII so add the proper conditional in the caller code. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
emac.c implements cpu_eth_init() so it needs to pull the corresponding header file. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Tom Rini <trini@konsulko.com> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org>
-
The AT91-based platforms have a mem_init() function declared in arch/arm/mach-at91/include/mach/at91_common.h and implemented in various places. In preparation of the introduction of the lwIP networking library which also has a global mem_init() function, rename the AT91 one to at91_mem_init(). Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org> Reviewed-by:
Heiko Schocher <hs@denx.de> Reviewed-by:
Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
-
Prefix the flash status codes (ERR_*) with FL_ in order to avoid clashes with third-party libraries. Case in point: including the lwIP library header file <lwip/err.h> which defines err_enum_t as an enum with values being ERR_*. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Tom Rini <trini@konsulko.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org> Reviewed-by:
Peter Robinson <pbrobinson@gmail.com>
-
When building for sandbox, self.cross is empty. In MakeEnvironment(), CROSS_COMPILE is defined to be self.cross (with or without a full path), optionally prefixed by the toolchain wrapper defined in ~/.buildman. This is fine when self.cross is not empty, but it doesn't make sense when it is: - Either there is no wrapper and we end up with an empty CROSS_COMPILE which is the same as not defining it (the host compiler will be used), - Or there is a wrapper and CROSS_COMPILE will contain only the wrapper which obviously is not a valid compiler, hence an error. Test case: $ sudo apt install ccache $ grep -q toolchain-wrapper ~/.buildman || \ printf "[toolchain-wrapper]\nwrapper = ccache\n" >>~/.buildman $ make mrproper $ ./tools/buildman/buildman sandbox_noinst $ ./tools/buildman/buildman sandbox_noinst Building current source for 1 boards (1 thread, 24 jobs per thread) sandbox: + sandbox_noinst +arch/sandbox/lib/reloc_sandbox_efi.c:10:15: error: operator '==' has no left operand + 10 | #if HOST_ARCH == HOST_ARCH_X86_64 + | ^~ [...] The GetEnvArgs function is modified too, since the VAR_CROSS_COMPILE case has the same issue. In tools/buildman/test.py, testGetEnvArgs is extended and testMakeEnvironment is added. They check the 'arm' and 'sandbox' toolchains, with and without a wrapper. Signed-off-by:
Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Tom Rini authored
When running the bootstage tests currently we get a warning like: tests/test_bootstage.py::test_bootstage_stash ...PytestReturnNotNoneWarning: Expected None, but tests/test_bootstage.py::test_bootstage_stash returned (37748736, 4096), which will be an error in a future version of pytest. Did you mean to use `assert` in stead of `return`? This is because the unstash test will run the stash test and fetch the addr / size from that. Rework the test to be stash and unstash and then run the unstash command at the end of the current stash test. Acked-by:
Michal Simek <michal.simek@amd.com> Reviewed-by:
Love Kumar <love.kumar@amd.com> Reviewed-by:
Simon Glass <sjg@chromium.org> Signed-off-by:
Tom Rini <trini@konsulko.com>
-