- Oct 18, 2024
-
-
Without asm/cpu_x86.h inclusion a compiler is not happy: arch/x86/cpu/cpu_x86.c:14:5: warning: no previous prototype for ‘cpu_x86_bind’ [-Wmissing-prototypes] arch/x86/cpu/cpu_x86.c:29:5: warning: no previous prototype for ‘cpu_x86_get_vendor’ [-Wmissing-prototypes] arch/x86/cpu/cpu_x86.c:41:5: warning: no previous prototype for ‘cpu_x86_get_desc’ [-Wmissing-prototypes] arch/x86/cpu/cpu_x86.c:55:5: warning: no previous prototype for ‘cpu_x86_get_count’ [-Wmissing-prototypes] Add missing header inclusion. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
The compiler is not happy to have no prototypes for the functions that are not defined static. Add them. This helps avoiding the compiler warnings: arch/x86/cpu/cpu.c:197:13: warning: no previous prototype for ‘board_final_init’ [-Wmissing-prototypes] arch/x86/cpu/cpu.c:205:13: warning: no previous prototype for ‘board_final_cleanup’ [-Wmissing-prototypes] arch/x86/cpu/cpu.c:307:5: warning: no previous prototype for ‘reserve_arch’ [-Wmissing-prototypes] Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Some functions are not used anywhere except the same file where they are defined. Mark them static. This helps avoiding the compiler warnings: arch/x86/cpu/cpu.c:343:6: warning: no previous prototype for ‘detect_coreboot_table_at’ [-Wmissing-prototypes] arch/x86/cpu/mtrr.c:90:6: warning: no previous prototype for ‘mtrr_write_all’ [-Wmissing-prototypes] arch/x86/cpu/i386/interrupt.c:240:6: warning: no previous prototype for ‘__do_irq’ [-Wmissing-prototypes] Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Most of the copies of the print_cpuinfo() call the default method. Remove all of those in order to have only the default one when no `cpu` command is compiled. This also helps avoiding compiler warning, e.g.: arch/x86/cpu/tangier/tangier.c:23:5: warning: no previous prototype for ‘print_cpuinfo’ [-Wmissing-prototypes] Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
The real-time clock is needed for most X86 systems and it is useful to be able to read from it. Enable the rtc command by default. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
This is in the Dockerfile now, so update this section of the docs. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Update to a newer version which supports settings in CMOS RAM and linear framebuffer. Signed-off-by:
Simon Glass <sjg@chromium.org> Reviewed-by:
Tom Rini <trini@konsulko.com>
-
Simon Glass authored
Some files may include this header file without first including dm.h so add a forward declaration. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
This function is really just an assignment, so serves no useful purpose. Drop it. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
The scene_txt_str() function calls expo_str() so there is no need to call it beforehand. Drop this unnecessary code. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Update the cedit read/write functions to support menu items with values. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Add some more logging in the CMOS read/write code. Tidy up a few comments while we are here. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
At present menu items are stored according to their sequence number in the menu. In some cases we may want to have holes in that sequence, or not use a sequence at all. Add a new 'value' property for menu items. This will be used for reading and writing, if present. If there is no 'value' property, then the normal sequence number will be used instead. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Set aside some expo IDs for 'save' and 'discard' buttons. This avoids needing to store the IDs for these. Adjust the documentation and expo tool for the new EXPOID_BASE_ID value. Ignore these objects when saving and loading the cedit, since they do not contain real data. Adjust 'cedit run' to return failure when the user exits the expo without saving. Update the test for this change as well. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
If expo_set_dynamic_start() is never called, the first scene created will have an ID of 0, which is invalid. Correct this by setting a default value. Add a test to check this. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
At present a fixed position is used for menu items, 200 pixels to the right of the left side of the labels. This means that a menu item with a very long label may overlap the items. It seems better to calculate the maximum label width and then place the items to the right of all of them. To implement this, add a new struct to containing arrangement information. Calculate it before doing the actual arrangement. Add a new style item which sets the amount of space from the right side of the labels to left side of the items. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
When starting a new text line, an assumption is made that the current vertical position is a multiple of the character height. When this is not true, characters can be written after the end of the framebuffer. This can causes crashes and strange errors from QEMU. Adjust the scrolling check when processing a newline character, to avoid any problems. Add some comments to make things a little clearer. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
This is useful for highlighting something with a black background, as is needed with cedit when using a white-on-black console. Add this as a new colour. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
This phandle was missing in the sandbox DT, add it, otherwise sandbox-i2c driver cannot look up the emulator via i2c_emul_find(). This fixes the following i2c_emul_find() error: " $ ./u-boot -Dc "" ... i2c_emul_find() No emulators for device 'sandbox_pmic' sandbox_pmic_write() write error to device: 0000000018c568d0 register: 0x0! out_set_value() PMIC write failed: -5 i2c_emul_find() No emulators for device 'sandbox_pmic' sandbox_pmic_write() write error to device: 0000000018c568d0 register: 0x0! out_set_value() PMIC write failed: -5 ... " Signed-off-by:
Marek Vasut <marex@denx.de> Reviewed-by:
Heiko Schocher <hs@denx.de> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Provide a short description of how tests work, why they are so critical and how to resolve gaps in Binman's test coverage. Signed-off-by:
Simon Glass <sjg@chromium.org> Acked-by:
Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com>
-
Simon Glass authored
Pass the arguments through to test_util so that a single test can be used. Update the docs and add some missing backquotes in the same section. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
At present run_test_coverage() assumes you want code coverage for the entire code base. This is the normal situation, but sometimes it is useful to see the coverage provided by just a single test. Add support for this. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
With sandbox_spl we want to use the file-based boot in CI, so that this flow is tested. The recent UPL change enabled booting via that method, thus overriding the file-based boot. Correct this by using UPL only when the --upl flag is given. Signed-off-by:
Simon Glass <sjg@chromium.org> Fixes: 91fde8e1 ("sandbox: Add an SPL loader for UPL")
-
Simon Glass authored
With Python 3.12 some warnings have cropped up. Fix them. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
The patch implement new property 'fit,sign' that can be declared at the top-level 'fit' node. If that option is declared, fit tryies to detect private keys directory among binman include directories. That directory than passed to mkimage using '-k' flag and that enable signing of FIT. Signed-off-by:
Alexander Kochetkov <al.kochet@gmail.com> Reviewed-by:
Simon Glass <sjg@chromium.org> Renumbered files, moved new tests to end: Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Fix error message like this: Can't add verification data for node 'fdt-1' (<unknown error>) We get unknown error because we decode error as fdt error but actually it is system error. Signed-off-by:
Alexander Kochetkov <al.kochet@gmail.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
FIT use mkimage from BuildSectionData() to build FIT entry contents. BuildSectionData() get called several times during building FIT image. Currently when fit inserts loadables, it use self._loadables property that contain loadables computed during previuos BuildSectionData() invocation. So for the first run it use empty list and pass no loadables to mkimage. That makes problem for adding signature to FIT image because mkimage fails to add signature and aborts building FIT if no loadables provided. The patch fixes described behaviour in a way that BuildSectionData() uses recently calculated loadables value, not previosly calculated. Signed-off-by:
Alexander Kochetkov <al.kochet@gmail.com> Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
When BLK is not enabled but BOOTSTD is, some features of standard boot become unavailable. Add a check for this in the only site that is currently apparent. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Some boards still don't enable BLK but we want to be able to at least compile the code which relies on this. For example, bootstd includes calls to blk_...() functions, albeit with a check for BLK so that the code is eliminated by the compiler. Reduce the scope of the BLK #ifdef to help with this. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Bring this information into bootstage. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Receiving timestamps from coreboot was unceremoniously dropped some time ago. Add it back. Signed-off-by:
Simon Glass <sjg@chromium.org> Fixes: 8ad01ce3 ("x86: Remove x86 specific GD flags as they are...")
-
Simon Glass authored
Rather than using a special variable, get the timestamp info from the coreboot sysinfo struct. Return a proper error as well. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
It is useful to obtain the results of MSR queries as well as to update MSR registers, so add a command these tasks. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
It is useful to obtain the results of cpuid queries, so add a command for this. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Since we are using the code from Linux, update it to the newer version in v6.11 Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
When the clock speed is above about 4GHz, e.g. on modern PC hardware, the timer overflows, resulting in a much lower frequency than expected. Deal with this by capping the clock speed. It would be possible to move to a 64-bit value for the clock, but that is a pain to deal with. A better approach might be to express the clock in MHz but that is left for later consideration. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
When bootstage is used the timer can be inited before the CPU identity is set up, resulting in the checks for the vendor not working. Add a special call to work around this. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Simon Glass authored
Refactor the cpu code and use it to show the CPU vendor, e.g. AuthenticAMD or GenuineIntel Signed-off-by:
Simon Glass <sjg@chromium.org>
-
Co-developed-by:
Cody Schuffelen <schuffelen@google.com> Signed-off-by:
Cody Schuffelen <schuffelen@google.com> Signed-off-by:
Dmitrii Merkurev <dimorinny@google.com> Cc: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> Cc: Simon Glass <sjg@chromium.org> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com> Cc: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org> Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # sandbox
-
While a few SoCs have a unique print_cpuinfo function, a number of them just use default_print_cpuinfo. Make default_print_cpuinfo have a weak alias to provie print_cpuinfo. Signed-off-by:
Tom Rini <trini@konsulko.com>
-