reset: Remove addr parameter from reset_cpu()
Historically, the reset_cpu() function had an `addr` parameter which was meant to pass in an address of the reset vector location, where the CPU should reset to. This feature is no longer used anywhere in U-Boot as all reset_cpu() implementations now ignore the passed value. Generic code has been added which always calls reset_cpu() with `0` which means this feature can no longer be used easily anyway. Over time, many implementations seem to have "misunderstood" the existence of this parameter as a way to customize/parameterize the reset (e.g. COLD vs WARM resets). As this is not properly supported, the code will almost always not do what it is intended to (because all call-sites just call reset_cpu() with 0). To avoid confusion and to clean up the codebase from unused left-overs of the past, remove the `addr` parameter entirely. Code which intends to support different kinds of resets should be rewritten as a sysreset driver instead. This transformation was done with the following coccinelle patch: @@ expression argvalue; @@ - reset_cpu(argvalue) + reset_cpu() @@ identifier argname; type argtype; @@ - reset_cpu(argtype argname) + reset_cpu(void) { ... } Signed-off-by:Harald Seiler <hws@denx.de> Reviewed-by:
Simon Glass <sjg@chromium.org>
Showing
- arch/arc/lib/reset.c 2 additions, 2 deletionsarch/arc/lib/reset.c
- arch/arm/cpu/arm920t/ep93xx/cpu.c 1 addition, 1 deletionarch/arm/cpu/arm920t/ep93xx/cpu.c
- arch/arm/cpu/arm920t/imx/timer.c 1 addition, 1 deletionarch/arm/cpu/arm920t/imx/timer.c
- arch/arm/cpu/arm926ejs/armada100/timer.c 1 addition, 1 deletionarch/arm/cpu/arm926ejs/armada100/timer.c
- arch/arm/cpu/arm926ejs/mx25/reset.c 1 addition, 1 deletionarch/arm/cpu/arm926ejs/mx25/reset.c
- arch/arm/cpu/arm926ejs/mx27/reset.c 1 addition, 1 deletionarch/arm/cpu/arm926ejs/mx27/reset.c
- arch/arm/cpu/arm926ejs/mxs/mxs.c 2 additions, 2 deletionsarch/arm/cpu/arm926ejs/mxs/mxs.c
- arch/arm/cpu/arm926ejs/spear/reset.c 1 addition, 1 deletionarch/arm/cpu/arm926ejs/spear/reset.c
- arch/arm/cpu/arm946es/cpu.c 1 addition, 1 deletionarch/arm/cpu/arm946es/cpu.c
- arch/arm/cpu/armv7/bcm281xx/reset.c 1 addition, 1 deletionarch/arm/cpu/armv7/bcm281xx/reset.c
- arch/arm/cpu/armv7/bcmcygnus/reset.c 1 addition, 1 deletionarch/arm/cpu/armv7/bcmcygnus/reset.c
- arch/arm/cpu/armv7/bcmnsp/reset.c 1 addition, 1 deletionarch/arm/cpu/armv7/bcmnsp/reset.c
- arch/arm/cpu/armv7/ls102xa/cpu.c 1 addition, 1 deletionarch/arm/cpu/armv7/ls102xa/cpu.c
- arch/arm/cpu/armv7/s5p4418/cpu.c 1 addition, 1 deletionarch/arm/cpu/armv7/s5p4418/cpu.c
- arch/arm/cpu/armv7/stv0991/reset.c 1 addition, 1 deletionarch/arm/cpu/armv7/stv0991/reset.c
- arch/arm/cpu/armv7m/cpu.c 1 addition, 1 deletionarch/arm/cpu/armv7m/cpu.c
- arch/arm/cpu/armv8/fsl-layerscape/cpu.c 2 additions, 2 deletionsarch/arm/cpu/armv8/fsl-layerscape/cpu.c
- arch/arm/cpu/armv8/s32v234/generic.c 1 addition, 1 deletionarch/arm/cpu/armv8/s32v234/generic.c
- arch/arm/cpu/pxa/pxa2xx.c 2 additions, 2 deletionsarch/arm/cpu/pxa/pxa2xx.c
- arch/arm/cpu/sa1100/cpu.c 1 addition, 1 deletionarch/arm/cpu/sa1100/cpu.c
Loading
Please register or sign in to comment