Skip to content
Snippets Groups Projects
Commit 5b15a259 authored by Simon Glass's avatar Simon Glass Committed by Tom Rini
Browse files

mkimage: Don't close the file if it wasn't opened


The error path for fit_import_data() is incorrect if the second open() call
fails.

Reported-by: Coverity (CID: 138489)
Signed-off-by: Simon Glass's avatarSimon Glass <sjg@chromium.org>
Reviewed-by: default avatarTom Rini <trini@konsulko.com>
parent 3bd3a54a
No related branches found
No related tags found
No related merge requests found
......@@ -537,8 +537,8 @@ static int fit_import_data(struct image_tool_params *params, const char *fname)
if (fd < 0) {
fprintf(stderr, "%s: Can't open %s: %s\n",
params->cmdname, fname, strerror(errno));
ret = -EIO;
goto err;
free(fdt);
return -EIO;
}
if (write(fd, fdt, new_size) != new_size) {
debug("%s: Failed to write external data to file %s\n",
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment