Skip to content
Snippets Groups Projects
Commit 69414d86 authored by Dario Binacchi's avatar Dario Binacchi Committed by Tom Rini
Browse files

pinctrl: single: check function mask to be non-zero


Otherwise it can generate a division by zero, which has an undefined
behavior.

Signed-off-by: default avatarDario Binacchi <dariobin@libero.it>
parent 7ac7038a
No related branches found
No related tags found
No related merge requests found
......@@ -335,6 +335,10 @@ static int single_configure_bits(struct udevice *dev,
phys_addr_t reg;
u32 offset, val, mask, bit_pos, val_pos, mask_pos, submask;
/* If function mask is null, needn't enable it. */
if (!pdata->mask)
return 0;
npins_in_reg = pdata->width / priv->bits_per_pin;
func = single_allocate_function(dev, count * npins_in_reg);
if (IS_ERR(func))
......@@ -469,6 +473,11 @@ static int single_probe(struct udevice *dev)
priv->npins = size / (pdata->width / BITS_PER_BYTE);
if (pdata->bits_per_mux) {
if (!pdata->mask) {
dev_err(dev, "function mask needs to be non-zero\n");
return -EINVAL;
}
priv->bits_per_pin = fls(pdata->mask);
priv->npins *= (pdata->width / priv->bits_per_pin);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment