- May 18, 2020
-
-
Move this uncommon header out of the common header. Signed-off-by:Simon Glass <sjg@chromium.org>
-
- May 10, 2020
-
-
For dual ethernet controllers, the HW design may connect ETH phys to one MDIO ports. So two different ethernet drivers have to share MDIO bus. Since two ethernet drivers are independent, we can't ensure their probe order. To resolve this problem, introduce an eth phy generic driver and uclass. After eth-uclass binds, we search the mdio node and binds the phy node with the eth-phy-generic driver. When one eth driver get its phy device, the parent of phy device will probe prior than phy device. So this ensure the eth driver ownes the MDIO bus will be probed before using its MDIO. Signed-off-by:
Ye Li <ye.li@nxp.com> Signed-off-by:
Peng Fan <peng.fan@nxp.com>
-
Add return value check Signed-off-by:
-
- Apr 27, 2020
-
-
Remove the unneeded define TFTP_MTU_BLOCKSIZE. Since the KConfig migration done by commit b618b370 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig"), CONFIG_TFTP_BLOCKSIZE is always defined and can be used directly to avoid confusion (fallback to 1468 in code is never used). Signed-off-by:
Patrick Delaunay <patrick.delaunay@st.com>
-
Add help message for the CONFIG_TFTP_BLOCKSIZE default value, as explain in tftp.c before migration in commit b618b370 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig") Signed-off-by:
-
- Apr 06, 2020
-
-
Michal Simek authored
When local-mac-address DT property is specified it is reported the same way as address read from eeprom/ROM. Show properly if mac address is coming from DT or ROM. Signed-off-by:Michal Simek <michal.simek@xilinx.com>
-
- Mar 09, 2020
-
-
When printing unsigned numbers use %u. Signed-off-by:
Heinrich Schuchardt <xypron.glpk@gmx.de> Acked-by:
Joe Hershberger <joe.hershberger@ni.com>
-
- Feb 13, 2020
-
-
Signed-off-by:
Rasmus Villemoes <rasmus.villemoes@prevas.dk> Reviewed-by:
-
- Feb 06, 2020
-
-
Simon Glass authored
At present dm/device.h includes the linux-compatible features. This requires including linux/compat.h which in turn includes a lot of headers. One of these is malloc.h which we thus end up including in every file in U-Boot. Apart from the inefficiency of this, it is problematic for sandbox which needs to use the system malloc() in some files. Move the compatibility features into a separate header file. Signed-off-by:
-
- Jan 24, 2020
-
-
These three globals relate to image handling. Move them to the image header file. Signed-off-by: -
These global variables are quite short and generic. In fact the same name is more often used locally for struct members and function arguments. Add a image_ prefix to make them easier to distinguish. Signed-off-by: -
This function belongs more in flash.h than common.h so move it. Also remove the space before the bracket in some calls. Signed-off-by:
-
- Jan 17, 2020
-
-
These three globals relate to image handling. Move them to the image header file. Signed-off-by: -
These global variables are quite short and generic. In fact the same name is more often used locally for struct members and function arguments. Add a image_ prefix to make them easier to distinguish. Signed-off-by: -
This function belongs more in flash.h than common.h so move it. Also remove the space before the bracket in some calls. Signed-off-by:
-
- Dec 15, 2019
-
-
These functions are used by code outside the network support, so move them to lib/ to be more accessible. Without this, the functions are only accessible in SPL/TPL only if CONFIG_SPL/TPL_NET are defined. Many boards do not enable those option but still want to do checksums in this format. Fix up a few code-style nits while we are here. Signed-off-by:
Bin Meng <bmeng.cn@gmail.com>
-
- Dec 09, 2019
-
-
The function connects an ethernet device to a PHY using DT information. This API is only available for eth devices with an associated device tree node. Signed-off-by:
Alex Marginean <alexandru.marginean@nxp.com> Acked-by:
-
Renamed dm_mdio_phy_connect arguments dev to mdiodev and addr to phyaddr for a bit more clarity and consistency with the following patches. Also use NULL instead of 0 on error return path. Signed-off-by:
-
Commit b618b370 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig") accidentally set the default *option* TFTP block size to 512 bytes, even though the comment in the code says that this is a terrible choice. Most boards didn't define the symbol before, so they got the default block size of 1468 bytes before, but now use 512 bytes, which is also the fallback. This leads to both abysmal performance and a lot of hashes printed on the screen (one character for every 5K), which is both annoying and slow over serial links. Set the default block size in Kconfig back to the value it had before. This improves TFTP performance from 2.8 MB/s to 6.9 MB/s on a Pine64. Fixes: b618b370 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig") Signed-off-by:
Andre Przywara <andre.przywara@arm.com> Acked-by:
-
device_probe() may fail in which case the seq_id will be -1. Don't display these devices during startup. While this is only a cosmetic change, the return value of eth_initialize() will also change to the actual number of available devices. The return value is only used in spl_net to decide whether there are any devices to boot from. So returning only available devices is also more correct in that case. Signed-off-by:
Michael Walle <michael@walle.cc> Acked-by:
-
During testing of qemu-riscv32 with a 2GiB memory configuration, tftp always fails with a error message: Load address: 0x84000000 Loading: # TFTP error: trying to overwrite reserved memory... It turns out the result of 'tftp_load_addr + tftp_load_size' just overflows (0x100000000) and the test logic in store_block() fails. Fix this by adjusting the end address to ULONG_MAX when overflow is detected. Fixes: a156c47e ("tftp: prevent overwriting reserved memory") Signed-off-by:
Bin Meng <bmeng.cn@gmail.com>
Acked-by: -
sandbox_defconfig does not compile using GCC 9.2.1: net/net.c: In function ‘net_process_received_packet’: net/net.c:1288:23: error: taking address of packed member of ‘struct ip_udp_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 1288 | sumptr = (ushort *)&(ip->udp_src); | ^~~~~~~~~~~~~~ Avoid the error by using a u8 pointer instead of an u16 pointer and in-lining ntohs(). Simplify the checksumming of the last message byte. Signed-off-by:Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> Acked-by:
-
While we have networking use cases within SPL we do not support loading files via NFS at this point in time. Disable calling nfs_start() so that the NFS related code can be garbage collected at link time. Signed-off-by:
Tom Rini <trini@konsulko.com> Acked-by:
-
Joe Hershberger authored
Part of the env cleanup moved this out of the environment code and into the net code. However, this helper is sometimes needed even when the net stack isn't included. Move the helper to lib/net_utils.c like it's similarly-purposed string_to_ip(). Also rename the moved function to similar naming. Signed-off-by:
Ondrej Jirman <megous@megous.com>
-
- Dec 02, 2019
-
-
This function belongs in time.h so move it over and add a comment. Signed-off-by:
-
Create a new rand.h header file and move functions into it, to reduce the size of common.h Signed-off-by:
-
This feature is not enabled by any board. Drop it. Signed-off-by:
-
- Sep 04, 2019
-
-
With GCC 9.2.1 net/nfs.c leads to multiple errors of type address-of-packed-member. net/nfs.c: In function ‘rpc_req’: net/nfs.c:199:18: error: taking address of packed member of ‘struct rpc_t’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 199 | p = (uint32_t *)&(rpc_pkt.u.call.data); | ^~~~~~~~~~~~~~~~~~~~~~ net/nfs.c: In function ‘nfs_readlink_reply’: net/nfs.c:631:46: error: taking address of packed member of ‘struct rpc_t’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 631 | nfs3_get_attributes_offset(rpc_pkt.u.reply.data); | ~~~~~~~~~~~~~~~^~~~~ LD drivers/block/built-in.o net/nfs.c: In function ‘nfs_read_reply’: net/nfs.c:692:46: error: taking address of packed member of ‘struct rpc_t’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 692 | nfs3_get_attributes_offset(rpc_pkt.u.reply.data); | ~~~~~~~~~~~~~~~^~~~~ struct rpc_t is only used as local variable. It is naturally packed. So there is no need for the attribute packed. Signed-off-by:Bin Meng <bmeng.cn@gmail.com>
Acked-by: -
rpc_pkt.u.call.data is an array of uint32_t. There is no need to convert it to uint32_t *. memcpy() expects void * as it 1st and 2nd argument. There is no point in converting pointers to char * before passing them to memcpy(). In ntohl(data[1]) != 0 calling ntohl() is superfluous. If the value is zero, does not depend on the byte order. Signed-off-by:
Bin Meng <bmeng.cn@gmail.com>
Acked-by: -
This patch adds a check to rpc_pkt.u.reply.data at nfs_lookup_reply. Signed-off-by:
Cheng Liu <liucheng32@huawei.com> Reported-by:
Fermín Serna <fermin@semmle.com> Acked-by:
-
This patch adds a check to rpc_pkt.u.reply.data at nfs_readlink_reply. Signed-off-by:
-
CVE-2019-14194/CVE-2019-14198: nfs: fix unbounded memcpy with a failed length check at nfs_read_reply This patch adds a check to rpc_pkt.u.reply.data at nfs_read_reply. Signed-off-by:
-
This patch adds a check to nfs_handler to fix buffer overflow for CVE-2019-14197, CVE-2019-14200, CVE-2019-14201, CVE-2019-14202, CVE-2019-14203 and CVE-2019-14204. Signed-off-by:
-
This patch adds a check to udp_len to fix unbounded memcpy for CVE-2019-14192, CVE-2019-14193 and CVE-2019-14199. Signed-off-by:
-
Use the optional property device-name to name the MDIO bus. This works around limitations with using the DT node name on devices such as Armada-8040, which integrates two cp100 cores, both featuring MDIOs at the same relative offsets and with the same DT node names. The concept was originally proposed by Marvell as a custom property called mdio-name specific to Marvell driver. This patch uses the more generic property device-name and moves this into MDIO class code so other can use it as well. Signed-off-by:
Alex Marginean <alexm.osslist@gmail.com> Acked-by:
Bin Meng <bmeng.cn@gmail.com> -
Add support for capturing ethernet packets and storing them in memory in PCAP(2.4) format, later to be analyzed by any PCAP viewer software (IE. Wireshark) This feature greatly assist debugging network issues such as detecting dropped packets, packet corruption etc. Signed-off-by:
Ramon Fried <rfried.dev@gmail.com> Reviewed-by:
-
Joe Hershberger authored
Don't allow unterminated strings Signed-off-by:
-
- Aug 11, 2019
-
-
This file contains lots of internal details about the environment. Most code can include env.h instead, calling the functions there as needed. Rename this file and add a comment at the top to indicate its internal nature. Signed-off-by:
-
This header file is now only used by files that access internal environment features. Drop it from various places where it is not needed. Acked-by:
-
This function fits better with the network subsystem, so move it. Signed-off-by:
-
