efi_loader: fix building crt0 on arm
Before the patch an undefined constant EFI_SUBSYSTEM was used in the crt0 code. The current version of binutils does not swallow the error. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888403 The necessary constant IMAGE_SUBSYSTEM_EFI_APPLICATION is already defined in pe.h. So let's factor out asm-generic/pe.h for the image subsystem constants and use it in our assembler code. IMAGE_SUBSYSTEM_SAL_RUNTIME_DRIVER does not exist in the specification let's use IMAGE_SUBSYSTEM_EFI_ROM instead. The include pe.h is only used in code maintained by Alex so let him be the maintainer here too. Reported-by:Andre Przywara <andre.przywara@arm.com> Signed-off-by:
Heinrich Schuchardt <xypron.glpk@gmx.de> Tested-by:
Vagrant Cascadian <vagrant@debian.org> Signed-off-by:
Alexander Graf <agraf@suse.de>
Showing
- MAINTAINERS 2 additions, 0 deletionsMAINTAINERS
- arch/arm/lib/crt0_aarch64_efi.S 3 additions, 1 deletionarch/arm/lib/crt0_aarch64_efi.S
- arch/arm/lib/crt0_arm_efi.S 3 additions, 1 deletionarch/arm/lib/crt0_arm_efi.S
- include/asm-generic/pe.h 21 additions, 0 deletionsinclude/asm-generic/pe.h
- include/pe.h 2 additions, 6 deletionsinclude/pe.h
- lib/efi_loader/efi_image_loader.c 1 addition, 1 deletionlib/efi_loader/efi_image_loader.c
include/asm-generic/pe.h
0 → 100644
Please register or sign in to comment