Skip to content
  • Karsten Merker's avatar
    net: phy: Realtek RTL8211B/C PHY ID fix · 563d8d93
    Karsten Merker authored and Tom Rini's avatar Tom Rini committed
    
    
    The RTL8211B_driver structure in drivers/net/phy/realtek.c contains a
    wrong PHY ID (0x1cc910 instead of 0x1cc912) in the uid field.
    
    The lowest four bits of the PHY ID encode the chip revision (B+C/D/E/F)
    of the RTL8211 and the code originally applied a mask of 0xfffff0 to
    the PHY ID, so that matching the PHY ID to the appropriate driver code
    was only done on the chip type (RTL8211), but not on a specific
    revision.
    
    After introduction of support for the RTL8211E, which needed another
    startup function than the older chip revisions, commit
    42205047 changed the mask to 0xffffff
    to make the chip revision relevant for the match, but didn't provide
    the now-relevant lower bits of the uid field for the RTL8211B/C.
    
    Fix this by setting the full PHY ID in the RTL8211B_driver uid field.
    
    Fixes: 42205047 ("net/phy: realtek: Fix the PHY ID mask to ensure the correct Realtek PHY is detected")
    Signed-off-by: default avatarKarsten Merker <merker@debian.org>
    Acked-by: Joe Hershberger's avatarJoe Hershberger <joe.hershberger@ni.com>
    563d8d93