Skip to content
Snippets Groups Projects
  1. Dec 06, 2023
  2. Dec 04, 2023
  3. Dec 03, 2023
  4. Dec 02, 2023
  5. Dec 01, 2023
  6. Nov 28, 2023
  7. Nov 27, 2023
    • Philip Oberfichtner's avatar
      i2c: Bugfix in i2c_get_chip_by_phandle() · acae7eb5
      Philip Oberfichtner authored and Tom Rini's avatar Tom Rini committed
      
      The "i2cbcdev" sneaked in when implementing this function for the
      bootcounter use case. Obviously the intention was to use prop_name
      instead.
      
      Fixes: b4835527 (i2c: Implement i2c_get_chip_by_phandle())
      
      Signed-off-by: default avatarPhilip Oberfichtner <pro@denx.de>
      Acked-by: default avatarHeiko Schocher <hs@denx.de>
      acae7eb5
    • Sam Protsenko's avatar
      configs: Remove unneeded SYS_CONFIG_NAME from a*y17lte defconfigs · 470682ac
      Sam Protsenko authored and Minkyu Kang's avatar Minkyu Kang committed
      
      As correct default SYS_CONFIG_NAME value is now set in
      board/samsung/axy17lte/Kconfig (in commit "board: samsung: Fix
      SYS_CONFIG_NAME configs in axy17lte Kconfig"), the SYS_CONFIG_NAME
      option can be safely removed from all a*y17lte defconfigs. That removal
      doesn't change resulting .config files.
      
      Signed-off-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
      Signed-off-by: Minkyu Kang's avatarMinkyu Kang <mk7.kang@samsung.com>
      470682ac
    • Sam Protsenko's avatar
      board: samsung: Fix SYS_CONFIG_NAME configs in axy17lte Kconfig · 6219b47c
      Sam Protsenko authored and Minkyu Kang's avatar Minkyu Kang committed
      
      There is a couple of issues related to SYS_CONFIG_NAME config in
      axy17lte Kconfig.
      
      1. The global SYS_CONFIG_NAME in axy17lte Kconfig overrides
         SYS_CONFIG_NAME for all boards specified after this line in
         arch/arm/mach-exynos/Kconfig:
      
             source "board/samsung/axy17lte/Kconfig"
      
         Right now it's the last 'source' line there, so the issue is not
         reproducible. But once some board is moved or added after this line
         the next build error will happen:
      
             GEN     include/autoconf.mk.dep
           In file included from ./include/common.h:16:
           include/config.h:3:10: fatal error: configs/exynos78x0-common.h.h:
                                  No such file or directory
               3 | #include <configs/exynos78x0-common.h.h>
                 |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           compilation terminated.
      
         That's happening because axy17lte Kconfig defines SYS_CONFIG_NAME
         option in global namespace (not guarded with any "if TARGET_..."), so
         it basically rewrites the correct SYS_CONFIG_NAME defined in the
         hypothetical boards which might appear after axy17lte in mach-exynos
         Kconfig.
      
      2. Another side of the issue is that SYS_CONFIG_NAME is defined
         incorrectly in axy17lte Kconfig:
      
             config SYS_CONFIG_NAME
                 default "exynos78x0-common.h"
      
         The .h extension should not have been specified there. It's leading
         to a build error, as the generated include file has a double '.h'
         extension.
      
      3. Each target in axy17lte/Kconfig defines its own SYS_CONFIG_NAME. But
         all of those in fact incorrect, as corresponding
         include/configs/<CONFIG_SYS_CONFIG_NAME>.h header files don't exist.
      
      4. The global SYS_CONFIG_NAME pretty much repeats the help description
         from arch/Kconfig and doc/README.kconfig.
      
      Corresponding defconfig files (a*y17lte_defconfig) fix above issues by
      overriding SYS_CONFIG_NAME and correctly setting it to
      "exynos78x0-common".
      
      Fix all mentioned issues by removing the incorrect global
      SYS_CONFIG_NAME and instead specifying it (correctly) in SYS_CONFIG_NAME
      options for each target instead.
      
      Signed-off-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
      Fixes: 3e2095e9 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)")
      Signed-off-by: Minkyu Kang's avatarMinkyu Kang <mk7.kang@samsung.com>
      6219b47c
    • Sam Protsenko's avatar
      serial: s5p: Use dev_read_addr_ptr() to get base address · 33e7ca5a
      Sam Protsenko authored and Minkyu Kang's avatar Minkyu Kang committed
      
      As the address read from device tree is being cast to a pointer, it's
      better to use dev_read_addr_ptr() API for getting that address. The more
      detailed explanation can be found in commit a12a73b6 ("drivers: use
      dev_read_addr_ptr when cast to pointer").
      
      Signed-off-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
      Reviewed-by: Simon Glass's avatarSimon Glass <sjg@chromium.org>
      Signed-off-by: Minkyu Kang's avatarMinkyu Kang <mk7.kang@samsung.com>
      33e7ca5a
  8. Nov 25, 2023
  9. Nov 23, 2023
  10. Nov 21, 2023
  11. Nov 20, 2023
Loading