- Dec 06, 2023
-
-
The current emac setting is not suitable for Orange Pi Zero 3, move it back to Orange Pi Zero 2 DT. Also update phy mode and delay values for emac on Orange Pi Zero 3. With these changes, Ethernet now looks stable. Fixes: 95c3b063 ("sunxi: dts: arm64: update devicetree files from Linux-v6.6-rc6") Signed-off-by:
Chukun Pan <amadeus@jmu.edu.cn> Reviewed-by:
Jernej Skrabec <jernej.skrabec@gmail.com>
-
The mtd_debug write does not work in this context. The flashcp command does work, provides both the erase and write functions and with the verbose option gives good feedback. Signed-off-by:
Stephen Graf <stephen.graf@gmail.com> Reviewed-by:
Andre Przywara <andre.przywara@arm.com>
-
André Przywara authored
When using the USB OTG FEL mode on the Allwinner H616, the BootROM stores some data at the end of SRAM C. This is also the location where we place the initial SPL stack, so it will overwrite this data. We still need the BROM code after running the SPL, so should leave that area alone. Interestingly this does not seem to have an adverse effect, I guess on the "way out" (when we return to FEL after the SPL has run), this data is not needed by the BROM, for just the trailing end of the USB operation. However this is still wrong, and we should not clobber BROM data. Lower the SPL stack address to be situated right below the swap buffers we use in sunxi-fel: that should be out of the way of everyone else. This obsoletes a previous commit (eb53e774) with the same name: that one was changing the address in an *unused* macro in sunxi_common.h, so the previous patch didn't have any effect at all. Fixes: eb53e774 ("sunxi: h616: lower SPL stack address to avoid BROM data") Signed-off-by:
Andre Przywara <andre.przywara@arm.com>
-
André Przywara authored
The OrangePi Zero 2 has a USB VBUS regulator, controlled by pin PC16. This is correctly described in the DT, but the patches for supporting this are still pending. Meanwhile add our good old CONFIG_USB1_VBUS_PIN to the defconfig file, to enable power on the USB port and allow using a USB flash drive, for instance. Fixes: 6acc5fa5 ("sunxi: H616: enable USB support for H616 boards") Reported-by:
Mikhail Kalashnikov <iuncuim@gmail.com> Signed-off-by:
Andre Przywara <andre.przywara@arm.com>
-
- Dec 04, 2023
-
-
Tom Rini authored
Signed-off-by:
Tom Rini <trini@konsulko.com>
-
We currently use an outdated format 32-bit format for SMBIOS tables. So we must allocate SMBIOS tables below 4 GiB. Signed-off-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org> Tested-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org>
-
https://source.denx.de/u-boot/custodians/u-boot-watchdogTom Rini authored
- Correct watchdog timeout print message (Chanho Park)
-
The wdt_start function takes timeout_ms as a parameter and starts the watchdog with this value. However, when you output the message, it shows the default timeout value for the watchdog device. So this patch fixes that part to output the correct timeout value. Before --> StarFive # wdt start 3000 WDT: Started watchdog@13070000 without servicing (60s timeout) After --> StarFive # wdt start 3000 WDT: Started watchdog@13070000 without servicing (3s timeout) Fixes: c2fd0ca1 ("watchdog: Integrate watchdog triggering into the cyclic framework") Signed-off-by:
Chanho Park <chanho61.park@samsung.com> Reviewed-by:
Stefan Roese <sr@denx.de>
-
- Dec 03, 2023
-
- Dec 02, 2023
-
-
-
Cong Dang authored
As requirement of CR side, QSPI Flash usage via RPC driver shall be disabled and leaving the control of this module to CR side. Perform DT modification to disable the RPC SPI. Reviewed-by:
Marek Vasut <marek.vasut+renesas@mailbox.org> Signed-off-by:
Cong Dang <cong.dang.xn@renesas.com> Signed-off-by:
Marek Vasut <marek.vasut+renesas@mailbox.org> [Marek: Do not modify defconfig, modify the DT instead, this way the RPC SPI can be enabled without recompiling the U-Boot itself. Update commit message accordingly.]
-
Marek Vasut authored
Use the phandle reference to &rpc node in arch/arm/dts/r8a779g0.dtsi and remove properties which are already in arch/arm/dts/r8a779g0.dtsi. No functional change and no resulting DT change. Signed-off-by:
Marek Vasut <marek.vasut+renesas@mailbox.org>
-
- Dec 01, 2023
-
-
Compiling with CONFIG_USB_XHCI_PCI and CONFIG_PCI=n results in usb/host/xhci-pci.c:48:(.text.xhci_pci_probe+0x44): undefined reference to `dm_pci_write_config32 Add the missing Kconfig dependency. Signed-off-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by:
Mark Kettenis <kettenis@openbsd.org> Reviewed-by:
Marek Vasut <marex@denx.de>
-
Like Rockchip RK3328 and RK3568, the RK3588 also have a single node to represent the glue and ctrl for USB 3.0. Use rk_ops as driver data to select correct ctrl node for RK3588 DWC3. Signed-off-by:
Jonas Karlman <jonas@kwiboo.se> Reviewed-by:
Kever Yang <kever.yang@rock-chips.com> Reviewed-by:
Marek Vasut <marex@denx.de>
-
USB UFI uses fixed 12-byte commands (as does RBC, which is not supported), but SCSI does not have this limitation. Use the correct command block lengths depending on the subclass. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
Some devices like YubiKeys need more time before SET_ADDRESS. The spec says we need to wait 10ms. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
We need to get the DMA address before incrementing the pointer, as that might move us onto another segment. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
Now that we always check the return value, just return NULL on timeouts. We can still log the error since this is a problem, but it's not reason to panic. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
This isn't going to work, don't pretend it will and then end up timing out. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
There is currently no codepath to recover from this case. In principle we could require that the upper layer do this explicitly, but let's just do it in xHCI when the next bulk transfer is started, since that reasonably implies whatever caused the problem has been dealt with. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
There is a race where an endpoint may halt by itself while we are trying to halt it, which results in a context state error. See xHCI 4.6.9 which mentions this case. This also avoids BUGging when we attempt to stop an endpoint which was already stopped to begin with, which is probably a bug elsewhere but not a good reason to crash. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
If the xHC has a problem with our STOP ENDPOINT command, it is likely to return a completion directly instead of first a transfer event for the in-progress transfer. Handle that more gracefully. We still BUG() on the error code, but at least we don't end up timing out on the event and ending up with unexpected event errors. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
xhci_wait_for_event returns NULL on timeout, so the caller always has to check for that. This addresses immediate explosions in this part of the code when timeouts happen, but not the root cause for the timeout. Signed-off-by:
Hector Martin <marcan@marcan.st> Reviewed-by:
Marek Vasut <marex@denx.de>
-
- Nov 28, 2023
-
-
Update maintainers for Tegra SoC platform. Include device trees and drivers which contain tegra in the name. Signed-off-by:
Svyatoslav Ryhel <clamor95@gmail.com>
-
- Nov 27, 2023
-
-
The "i2cbcdev" sneaked in when implementing this function for the bootcounter use case. Obviously the intention was to use prop_name instead. Fixes: b4835527 (i2c: Implement i2c_get_chip_by_phandle()) Signed-off-by:
Philip Oberfichtner <pro@denx.de> Acked-by:
Heiko Schocher <hs@denx.de>
-
As correct default SYS_CONFIG_NAME value is now set in board/samsung/axy17lte/Kconfig (in commit "board: samsung: Fix SYS_CONFIG_NAME configs in axy17lte Kconfig"), the SYS_CONFIG_NAME option can be safely removed from all a*y17lte defconfigs. That removal doesn't change resulting .config files. Signed-off-by:
Sam Protsenko <semen.protsenko@linaro.org> Signed-off-by:
Minkyu Kang <mk7.kang@samsung.com>
-
There is a couple of issues related to SYS_CONFIG_NAME config in axy17lte Kconfig. 1. The global SYS_CONFIG_NAME in axy17lte Kconfig overrides SYS_CONFIG_NAME for all boards specified after this line in arch/arm/mach-exynos/Kconfig: source "board/samsung/axy17lte/Kconfig" Right now it's the last 'source' line there, so the issue is not reproducible. But once some board is moved or added after this line the next build error will happen: GEN include/autoconf.mk.dep In file included from ./include/common.h:16: include/config.h:3:10: fatal error: configs/exynos78x0-common.h.h: No such file or directory 3 | #include <configs/exynos78x0-common.h.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. That's happening because axy17lte Kconfig defines SYS_CONFIG_NAME option in global namespace (not guarded with any "if TARGET_..."), so it basically rewrites the correct SYS_CONFIG_NAME defined in the hypothetical boards which might appear after axy17lte in mach-exynos Kconfig. 2. Another side of the issue is that SYS_CONFIG_NAME is defined incorrectly in axy17lte Kconfig: config SYS_CONFIG_NAME default "exynos78x0-common.h" The .h extension should not have been specified there. It's leading to a build error, as the generated include file has a double '.h' extension. 3. Each target in axy17lte/Kconfig defines its own SYS_CONFIG_NAME. But all of those in fact incorrect, as corresponding include/configs/<CONFIG_SYS_CONFIG_NAME>.h header files don't exist. 4. The global SYS_CONFIG_NAME pretty much repeats the help description from arch/Kconfig and doc/README.kconfig. Corresponding defconfig files (a*y17lte_defconfig) fix above issues by overriding SYS_CONFIG_NAME and correctly setting it to "exynos78x0-common". Fix all mentioned issues by removing the incorrect global SYS_CONFIG_NAME and instead specifying it (correctly) in SYS_CONFIG_NAME options for each target instead. Signed-off-by:
Sam Protsenko <semen.protsenko@linaro.org> Fixes: 3e2095e9 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by:
Minkyu Kang <mk7.kang@samsung.com>
-
As the address read from device tree is being cast to a pointer, it's better to use dev_read_addr_ptr() API for getting that address. The more detailed explanation can be found in commit a12a73b6 ("drivers: use dev_read_addr_ptr when cast to pointer"). Signed-off-by:
Sam Protsenko <semen.protsenko@linaro.org> Reviewed-by:
Simon Glass <sjg@chromium.org> Signed-off-by:
Minkyu Kang <mk7.kang@samsung.com>
-
- Nov 25, 2023
-
-
https://source.denx.de/u-boot/custodians/u-boot-dfuTom Rini authored
u-boot-dfu-20231124 - Fix reinit for ChipIdea controller - Add missing newline in fastboot error handling
-
- Nov 23, 2023
-
-
Just some minor style fixes. No functional change. Signed-off-by:
Sam Protsenko <semen.protsenko@linaro.org> Reviewed-by:
Simon Glass <sjg@chromium.org> Signed-off-by:
Minkyu Kang <mk7.kang@samsung.com>
-
Get rid of magic numbers in s5p_serial_init() when writing to UART registers. While at it, use BIT() macro for existing constants when appropriate. No functional change. Signed-off-by:
Sam Protsenko <semen.protsenko@linaro.org> Reviewed-by:
Simon Glass <sjg@chromium.org> Signed-off-by:
Minkyu Kang <mk7.kang@samsung.com>
-
Use dev_read_u8_default() instead of fdtdec_get_int() to read the "id" property from device tree, as suggested in [1]. dev_* API is already used in this driver, so there is no reason to stick to fdtdec_* API. This also fixes checkpatch warning: WARNING: Use the livetree API (dev_read_...) [1] doc/develop/driver-model/livetree.rst Signed-off-by:
Sam Protsenko <semen.protsenko@linaro.org> Reviewed-by:
Simon Glass <sjg@chromium.org> Signed-off-by:
Minkyu Kang <mk7.kang@samsung.com>
-
It's not really needed here anymore. Remove it, as common.h is going away at some point. Signed-off-by:
Sam Protsenko <semen.protsenko@linaro.org> Reviewed-by:
Simon Glass <sjg@chromium.org> Signed-off-by:
Minkyu Kang <mk7.kang@samsung.com>
-
- Nov 21, 2023
-
-
https://source.denx.de/u-boot/custodians/u-boot-efiTom Rini authored
Pull request efi-2024-01-rc4 Documentation * Add HiSilicon board documentation to HTML docs * Fix building with Sphinx 6.0 UEFI * Increase default variable store size to 128K * Check return value of efi_append_scrtm version * Create shortened boot options in eficonfig command Other * Avoid incorrect error message in mkimage
-
Add missing newline in pr_err. Signed-off-by:
Simon Holesch <simon@holesch.de> Reviewed-by:
Marek Vasut <marex@denx.de> Reviewed-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com> Link: https://lore.kernel.org/r/20231120002024.32865-2-simon@holesch.de Signed-off-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com>
-
The ChipIdea device controller wasn't properly cleaned up when disabled. So enabling it again left it in a broken state. The problem occurred for example when the host unbinds the driver and binds it again. During the first setup, when the out request is queued, the endpoint is primed (`epprime`). If the endpoint is then disabled, it stayed primed with the initial buffer. So after the endpoint is re-enabled, the device controller and device driver were out of sync: the new out request was in the driver queue head, yet not submitted, but the "complete" function was still called, since the endpoint was primed with the old buffer. With the fastboot function this error led to the (rather confusing) error message "buffer overflow". Fixed by clearing the primed buffers with the `epflush` (`ENDPTFLUSH`) register. Signed-off-by:
Simon Holesch <simon@holesch.de> Reviewed-by:
Marek Vasut <marex@denx.de> Reviewed-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com> Link: https://lore.kernel.org/r/20231120002024.32865-1-simon@holesch.de Signed-off-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com>
-
- Nov 20, 2023
-
-
Heinrich Schuchardt authored
The boot options created by eficonfig should use shortened device-paths to avoid problems if drives are enumerated in a different sequence. Signed-off-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org>
-
Heinrich Schuchardt authored
It is unclear to developers why efi_var_from_file() returns EFI_SUCCESS if file ubootefi.var is missing or corrupted. Improve the description. Reported-by:
Weizhao Ouyang <o451686892@gmail.com> Signed-off-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by:
Weizhao Ouyang <o451686892@gmail.com>
-
The result of efi_append_scrtm_version() is overwritten before anyone checks its result. Check it and exit the function on failures Addresses-Coverity-ID: 467399 Code maintainability issues (UNUSED_VALUE) Fixes: commit 97707f12 ("tpm: Support boot measurements") Signed-off-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org> Reviewed-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
-