Skip to content
Snippets Groups Projects
  1. Feb 05, 2022
  2. Feb 04, 2022
  3. Feb 03, 2022
    • Tom Rini's avatar
      Merge branch '2022-02-03-assorted-fixes' · 3e5f4b33
      Tom Rini authored
      - Update CI image to have libgnutls available.
      - Assorted ARM and SPL bugfixes
      3e5f4b33
    • Simon Glass's avatar
      treewide: Use 16-bit Unicode strings · 5b9a5b2b
      Simon Glass authored and Tom Rini's avatar Tom Rini committed
      
      At present we use wide characters for Unicode but this is not necessary.
      Change the code to use the 'u' literal instead. This helps to fix build
      warnings for sandbox on the Raspberry Pi.
      
      Signed-off-by: Simon Glass's avatarSimon Glass <sjg@chromium.org>
      Reviewed-by: Heinrich Schuchardt's avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      5b9a5b2b
    • Simon Glass's avatar
      efi: Use 16-bit unicode strings · 156ccbc3
      Simon Glass authored and Tom Rini's avatar Tom Rini committed
      
      At present we use wide characters for unicode but this is not necessary.
      Change the code to use the 'u' literal instead. This helps to fix build
      warnings for sandbox on rpi.
      
      Signed-off-by: Simon Glass's avatarSimon Glass <sjg@chromium.org>
      Suggested-by: Heinrich Schuchardt's avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      Reviewed-by: Heinrich Schuchardt's avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      156ccbc3
    • Simon Glass's avatar
      scripts/checkpatch.pl: Resync with v5.16 · 587254eb
      Simon Glass authored and Tom Rini's avatar Tom Rini committed
      
      This resyncs us with the version found in v5.16 of the Linux kernel with
      the following exceptions:
      - Keep our u-boot specific tests / code area.
      - Change the location of checkpatch.rst
      - Drop the "use strscpy" test as we don't have that, but do have strlcpy
        and want that used now.
      - Keep debug/printf in the list for $logFunctions
      
      This also syncs the spdxcheck.py tool and all the associated
      documentation.
      S
      Signed-off-by: Simon Glass's avatarSimon Glass <sjg@chromium.org>
      587254eb
    • André Przywara's avatar
      armv8: start.S: remove CONFIG_SYS_RESET_SCTRL code · 68f08966
      André Przywara authored and Tom Rini's avatar Tom Rini committed
      There is some code that tries to "reset" the SCTLR_ELx register early in
      the boot process. The idea seems to be to guarantee some sane settings
      that U-Boot actually relies on, for instance running in little-endian
      mode, with the MMU off initially.
      However the current code has multiple problems:
      - For a start, no platform or config defines the symbol that would
        enable that code.
      - The code itself really only works if the bits that it tries to clear
        are already cleared:
        - If we run in big-endian mode initially, any previous loads would have
          been wrong already. That applies to the (optional) relocation code,
          but more prominently to the mask that it uses to clear those bits:
          "ldr x1, =0xfdfffffa" looks innocent, but actually involves a memory
          access to the literal pool, using the current endianness.
        - If we run with the MMU enabled, we are probably doomed already. We
          *could* hope that we are running with an identity mapping, but would
          need to do some cache maintenance to avoid losing dirty cache lines.
      - The idea of doing a read-modify-write of SCTLR is somewhat
        questionable to begin with, because as the owner of the current
        exception level we should initialise all bits of this register with a
        certain fixed value.
      - The code is unnecessarily complicated, and the function name is
        misspelled.
      
      While those problems *could* admittedly be fixed, the point that is does
      not seem to be used at all at the moment tells me we should just remove
      this code, and be it to not give a bad example.
      
      If people care, I could introduce some proper SCTLR initialisation code.
      We are about to work this out for the boot-wrapper[1] as we speak, but
      apparently we got away without doing this in U-Boot ever since, so it
      might not be worth the potential trouble.
      
      [1] https://lore.kernel.org/linux-arm-kernel/20220114105653.3003399-7-mark.rutland@arm.com/
      
      
      
      Signed-off-by: default avatarAndre Przywara <andre.przywara@arm.com>
      68f08966
Loading