- Aug 08, 2023
-
-
Fixes: 3db71108 ("crc32: Use the crc.h header for crc functions") Signed-off-by:
Ilya Lukin <4.shket@gmail.com>
-
The btrfs_decompress() function mostly (u32)-1 on error but it can also return -EPERM or other kernel error codes from zstd_decompress(). The "ret" variable is an int, so we could just check for negatives. Signed-off-by:
Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by:
Qu Wenruo <wqu@suse.com>
-
The x509_cert_parse() and pkcs7_parse_message() functions return error pointers. They don't return NULL. Update the checks accordingly. Signed-off-by:
Simon Glass <sjg@chromium.org>
-
This should be allocating the memory for "item" instead of "menu". The item struct is 48 bytes instead of 96 (assuming a 64bit system) so this saves a little memory. Signed-off-by:
-
Match the "=0x" instead of just "=0". Signed-off-by:
Heinrich.Schuchardt <xypron.glpk@gmx.de> Reviewed-by:
Ilias Apalodimas <ilias.apalodimas@linaro.org>
-
This line break is not done correctly. We don't want to have all those tabs in the printed output. Signed-off-by:
-
The u16_strlcat() is in units of u16 not bytes. So the limit needs to be ARRAY_SIZE() instead of sizeof(). Signed-off-by: -
These lines are supposed to be indented one more tab. Otherwise it's confusing to read. Signed-off-by:
Patrick Delaunay <patrick.delaunay@foss.st.com> -
We know that "pa" is non-NULL so it's nicer to just return zero instead of return !pa. This has no effect on runtime behavior. Signed-off-by:
-
The "oftree_count" is the number of entries which have been set in the oftree_list[] array. If all the entries have been initialized then this off by one would result in reading one element beyond the end of the array. Signed-off-by:
-
If btrfs_read_fs_root() fails with -ENOENT, then we go to the next entry. Fine. But if it fails for a different reason then we need to clean up and return an error code. In the current code it doesn't clean up but instead dereferences "root" and crashes. Signed-off-by:
Marek Behún <kabel@kernel.org> Reviewed-by:
-
The ec_command_inptr() function returns negative error codes or the number of bytes that it was able to read. The cros_ec_get_sku_id() function should return negative error codes. Right now it returns positive error codes or negative byte counts. Signed-off-by:
-
The VNBYTES() macro needs to have parentheses to prevent some (harmless) macro expansion bugs. The VNBYTES() macro is used like this: VID_TO_PIXEL(x) * VNBYTES(vid_priv->bpix) The * operation is done before the / operation. It still ends up with the same results, but it's not ideal. Signed-off-by:
-
The parentheses are in the wrong place so this passes the number of bytes to write as "sizeof(index_0) != TPM_SUCCESS" when just "sizeof(index_0)" was intended. (1 byte vs 4 bytes). Signed-off-by: -
This returns the wrong variable. It ends up returning NULL when it was suppose to return an error pointer. Signed-off-by: -
strlcat returns min(strlen(dest), count)+strlen(src). Make u16_strlcat's behaviour the same for consistency. Fixes: eca08ce9 ("lib/charset: add u16_strlcat() function") Signed-off-by:
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
-
Both the Linux kernel and libbsd agree that strlcpy() should always return strlen(src) and not include the NUL termination. The incorrect U-Boot implementation makes it impossible to check the return value for truncation, and breaks code written with the usual implementation in mind (for example, fdtdec_add_reserved_memory() was subtly broken). I reviewed all callers of strlcpy() and strlcat() and fixed them according to my understanding of the intended function. This reverts commit d3358ecc and adds related fixes. Fixes: d3358ecc ("lib: string: Fix strlcpy return value") Signed-off-by:
Sean Anderson <sean.anderson@seco.com>
-
- Aug 07, 2023
-
-
Tom Rini authored
Signed-off-by:Tom Rini <trini@konsulko.com>
-
Tom Rini authored
Rsync all defconfig files using moveconfig.py Signed-off-by: -
Tom Rini authored
- Update Azure jobs again, a few MAINTAINERS updates, a few Kconfig fixes, an erofs fix and a fix for the recent ten64 updates.
-
In [1] Sam points out an assertion does not hold true for 32-bit platforms, which only impacts Large File Support (LFS) API usage in erofs-utils according to Xiang [2]. We don't think these APIs are used in u-boot and this restriction could be safely removed. [1] https://lists.denx.de/pipermail/u-boot/2023-July/524679.html [2] https://lists.denx.de/pipermail/u-boot/2023-July/524727.html Fixes: 3a21e92f ("fs/erofs: Introduce new features including ztailpacking, fragments and dedupe") Signed-off-by:
Yifan Zhao <zhaoyifan@sjtu.edu.cn> Tested-by:
Sam Edwards <CFSworks@gmail.com>
-
Drop duplicate space in Kconfig symbol description. Signed-off-by:Marek Vasut <marex@denx.de>
-
CONFIG_$(SPL_TPL_)SYS_MALLOC_F_LEN is defined as hex. If set to zero manually, .config contains '0x0' and not '0' as value. The default value for CONFIG_SPL_SYS_MALLOC_F_LEN should not be set to 0 but to 0x0 if CONFIG_SPL_FRAMEWORK=n to match a manually set value. Fixes: c0126bd8 ("spl: Support bootstage, log, hash and early malloc in TPL") Fixes: b6169470 ("SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without SPL_FRAMEWORK by default") Signed-off-by:
Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by:
-
All SPL hash algorithm options are collected in lib/Kconfig. Move SPL_CRC32 there as well. Signed-off-by:
Oleksandr Suvorov <oleksandr.suvorov@foundries.io> Reviewed-by:
-
There is another SPL_MD5 option defined in lib/Kconfig. Renaming SPL_MD5_SUPPORT introduced duplicate option with different description. As for now FIT and hash algorithm options are not related to each others, removing a duplicate option seems OK. Fixes: 4b00fd1a ("Kconfig: Rename SPL_MD5_SUPPORT to SPL_MD5") Signed-off-by:
-
Tom Rini authored
In the common bloblist code we call crc32 to get a checksum for the data. Ensure we will have the CRC32 code via select. Signed-off-by: -
Add px30, rv1126 soc, and rockchip soc based boards. Signed-off-by:Kever Yang <kever.yang@rock-chips.com>
-
With this change the DT and binding files are under the at91 tree maintainer, and get_maintainer.pl correctly reports the entry. Signed-off-by:Eugen Hristev <eugen.hristev@collabora.com>
-
The retimer reset/power on logic was changed in a recent commit, however, it neglected to check if the commands sent to the board microcontroller (to control power to the retimer chip) actually completed. Add return checks for these operations so any failures will be reported to the user. Signed-off-by:
Mathew McBride <matt@traverse.com.au> Fixes: 7a041fea ("board: traverse: ten64: ensure retimer reset is done on new board revisions")
-
Update MAINTAINERS file. Add missing MAINTAINERS file for Spider, Whitehawk and V3HSK boards. Update mail addresses. Add file globs to match on DT and driver files related to these boards. The GRPEACH and R2DPLUS are special in that they are not R-Car and have their own set of specialized drivers. Signed-off-by:Marek Vasut <marek.vasut+renesas@mailbox.org>
-
Tom Rini authored
As Pali Rohár has asked to not be copied on changes to files he is not a specific maintainer of, add his address to .get_maintainer.ignore. Signed-off-by:
Michael Trimarchi <michael@amarulasolutions.com>
-
Tom Rini authored
To reduce overall job time, move a number of smaller jobs together. These should still be safely under 1 hour total time, but reducing the overall number of jobs should help with the queue slightly. Signed-off-by: -
Tom Rini authored
The job for rockchip vendor platforms has again gotten close to or exceeded one hour. Rework things such that we move the 32bit platforms back to the general 32bit ARM job (as there's time there) and make these build only the 64bit platforms. Signed-off-by:
-
- Aug 06, 2023
-
-
https://source.denx.de/u-boot/custodians/u-boot-dmTom Rini authored
binman support for Xilinx signing buildman minor fixes
-
- Aug 05, 2023
-
-
Simon Glass authored
Some boards use a MAINTAINERS entry to specify common files without referencing any defconfigs. This is allowed and should not result in a warning. Drop the warning in this case. Signed-off-by: -
Simon Glass authored
Recent refactoring changed buildman to continue operation after fetching a toolchain. Fix this. Fixes: b8680646 ("bulidman: Move toolchain handling to a function") Signed-off-by:
-
DM_POST_INIT was changed to DM_POST_INIT_F. To debug correct message, change type_name from dm_post_init to dm_post_init_f. Signed-off-by:
Jaehoon Chung <jh80.chung@samsung.com> Reviewed-by:
-
Add test for the 'xilinx-bootgen' etype Signed-off-by:
Lukas Funke <lukas.funke@weidmueller.com> Reviewed-by:
-
This adds a new etype 'xilinx-bootgen'. By using this etype it is possible to created an signed SPL (FSBL in Xilinx terms) for ZynqMP boards. The etype uses Xilinx Bootgen tools in order to transform the SPL into a bootable image and sign the image with a given primary and secondary public key. For more information to signing the FSBL please refer to the Xilinx Bootgen documentation. Here is an example of the etype in use: spl { filename = "boot.signed.bin"; xilinx-bootgen { pmufw-filename = "pmu-firmware.elf"; psk-key-name-hint = "psk0"; ssk-key-name-hint = "ssk0"; auth-params = "ppk_select=0", "spk_id=0x00000000"; u-boot-spl-nodtb { }; u-boot-spl-dtb { }; }; }; For this to work the hash of the primary public key has to be fused into the ZynqMP device and authentication (RSA_EN) has to be set. For testing purposes: if ppk hash check should be skipped one can add the property 'fsbl_config = "bh_auth_enable";' to the etype. However, this should only be used for testing(!). Signed-off-by: -
Add the Xilinx Bootgen as bintool. Xilinx Bootgen is used to create bootable SPL (FSBL in Xilinx terms) images for Zynq/ZynqMP devices. The btool creates a signed version of the SPL. Additionally to signing the key source for the decryption engine can be passend to the boot image. Signed-off-by:
-
